Return to previous page

Login Popup takes much to long until it disappears

This topic has 7 replies, 3 voices, and was last updated 7 years, 2 months ago ago by Rose Tyler

Royalty

Participant

February 7, 2017 at 20:36
Hello,
I noticed that the login popup takes extremely long until it disappears. Same for cart popup. At cart popup, I could solve this via css but for login popup, I had to edit etheme.js.
In line 1941 I found:
```
    var loginTimeout = 0;

    $( ".login-link" ).hover(
      function() {
        clearTimeout(loginTimeout);
        $( '.login-popup' ).addClass( 'hover_login' );
      },
      function() {

        loginTimeout = setTimeout(function () {
            $( '.login-popup' ).removeClass( 'hover_login' );
        }, 1500);
        
      }
    );
```
Whats the sense of this long timeout? Why isnt this done via css? I deleted the timeout completely and I wanted to ask if you could also remove this for the next update because it makes no sense and can be done via css….?
#154248 Copied
6 Answers

Royalty

Participant

February 7, 2017 at 20:45

Just wanted to add that I did not delete it completely because then other functions stopped working. But I set the time to 0.

#154249 Copied

Eva Kemp

Support staff

February 9, 2017 at 11:14

Hello,

Unfortunately we can’t delete that function because for other customers it won’t work.
If you want to remove it you should do this after theme update too.

Regards,
Eva Kemp.

#154384 Copied

Royalty

Participant

February 9, 2017 at 13:12

I am not sure if you understood me right:
I mean I want to remove the long waiting time until the popup closes, not the animation and the popup itself. The animation and the animation time can be handled via css so I dont see any reason why its done via javascript and why it has such a long waiting (1500ms) at all.

#154390 Copied

Eva Kemp

Support staff

February 9, 2017 at 16:44

Hello,

Sorry for misunderstanding.
This will be fixed in the next theme update.

Pleas take our apologies for inconveniences.

Regards,
Eva Kemp.

#154409 Copied

Royalty

Participant

February 9, 2017 at 16:46

Ok great, thank you very much!

#154410 Copied

Rose Tyler

Support staff

February 10, 2017 at 15:15

Hello,

You’re welcome!
Have a nice day!

Regards,
Rose Tyler.

#154475 Copied
Viewing 7 results - 1 through 7 (of 7 total)