Hello, @David,
Please make sure that you have turned the “Show Sale Percentage” & “Show Sale Percentage For Variable Products” turned ON from XStore >> Theme Settings >> WooCommerce >> Shop Element >> Product Badges: https://postimg.cc/GBzHnwsp
Regards 8Themes Team.