Rest API fix for portfolio.php - by mleihs

This topic has 10 replies, 3 voices, and was last updated 8 years, 2 months ago ago by Jack Richardson

  • Avatar: mleihs
    mleihs
    Participant
    February 8, 2016 at 09:42

    Hi,

    our developer fixed portfolio.php. It didn’t support the WordPress rest interface before that. Could you please pass that on to your developers so they’ll include it in the next version?

    Thanks!

    --- legenda/framework/portfolio.php    2016-02-05 22:30:40.034416257 +0100
    +++ legenda-till/framework/portfolio.php    2016-02-05
    22:30:49.154416246 +0100
    @@ -37,6 +37,9 @@
             'has_archive' => true,
             'hierarchical' => false,
             'menu_position' => null,
    +                'show_in_rest' => true,
    +                'rest_base' => 'etheme-portfolio',
    +                'rest_controller_class' => 'WP_REST_Posts_Controller',
             'supports' =>
    array('title','editor','author','thumbnail','excerpt','comments'),
             'rewrite' => array('slug' => 'project')
         );
    
    

    Best regards

    9 Answers
    Avatar: Eva
    Eva Kemp
    Support staff
    February 8, 2016 at 13:08

    Hello,

    We’ll forward your query to our developers.

    Thank you for the notice.

    Regards,
    Eva Kemp.

    Avatar: mleihs
    mleihs
    Participant
    February 8, 2016 at 13:14

    Thank you!

    Best regards

    Avatar: Eva
    Eva Kemp
    Support staff
    February 8, 2016 at 14:10

    Hello,

    You’re welcome.

    Have a nice day.

    Regards,
    Eva Kemp.

    Avatar: mleihs
    mleihs
    Participant
    February 15, 2016 at 18:37

    Hi,

    did they accept/include it?

    Best regards

    Avatar: Eva
    Eva Kemp
    Support staff
    February 15, 2016 at 20:19

    Hello,

    The developers haven’t implemented it yet.
    It may be done only after theme update.

    Regards,
    Eva Kemp.

    Avatar: mleihs
    mleihs
    Participant
    February 16, 2016 at 12:34

    Hi,

    I understand. I just wanted to know if they will include it in the next update or if they are going to discard it.

    Here’s an update:

    --- themes/legenda/framework/portfolio.php	2016-02-16 10:46:54.846097257 +0100
    +++ themes/legenda-till/framework/portfolio.php	2016-02-16 10:46:30.235097282 +0100
    @@ -37,7 +37,10 @@
     		'has_archive' => true,
     		'hierarchical' => false,
     		'menu_position' => null,
    -		'supports' => array('title','editor','author','thumbnail','excerpt','comments'),
    +		'show_in_rest' => true,
    +		'rest_base' => 'etheme-portfolio',
    +		'rest_controller_class' => 'WP_REST_Posts_Controller',
    +		'supports' => array('title','editor','author','thumbnail','excerpt','comments','page-attributes'),
     		'rewrite' => array('slug' => 'project')
     	);

    Best regards

    Avatar: Eva
    Eva Kemp
    Support staff
    February 16, 2016 at 14:18

    Hello,

    We just passed your query to senior support, they will discuss it.
    Unfortunately for now we can’t know if they implement it.

    Sorry for inconveniences.

    Regards,
    Eva Kemp.

    Avatar: mleihs
    mleihs
    Participant
    February 17, 2016 at 15:31

    Hi,

    ok. Please share their decision once they made it.

    Thank you!

    Best regards

    Avatar: Jack Richardson
    Jack Richardson
    Support staff
    February 17, 2016 at 15:45

    Hello,

    Ok, we took this into account.

    Thank you.
    Best regards,
    Jack Richardson.

  • Viewing 10 results - 1 through 10 (of 10 total)

You must be logged in to reply to this topic.Log in/Sign up

We're using our own and third-party cookies to improve your experience and our website. Keep on browsing to accept our cookie policy.