Your changes in our function.php - by 0rca

This topic has 8 replies, 3 voices, and was last updated 4 years, 7 months ago ago by Rose Tyler

  • Avatar: 0rca
    0rca
    Participant
    August 1, 2019 at 16:19

    Hi,

    A year ago you helped us with some code added to the child’s functions.php (private link 1) of our customer’s website. It seems that some of the changes are not playing nice with latest theme changes:

    Without your changes:

    private image1

    With your changes:

    private image2

    As you can see, the pagination is broken and the place holder images don’t show up. Can you see right away where the problem is?

    Apart from that, you will also see that I have been trying to remove some images sizes, but for some reason this won’t work. Do you know why?

    And last but not least I am having trouble understanding, why the theme is using the size “shop_catalog” for the product gallery thumbnails (private link 2) and not some thumbnail sized image. Or is this some error on my part?

    Thanks

    Michael

    Please, contact administrator
    for this information.
    7 Answers
    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    August 1, 2019 at 17:05

    Hello,

    Sorry, can’t login to your Dashboard http://prntscr.com/on2e16
    FTP access also does not work:
    Error: Connection timed out after 20 seconds of inactivity
    Error: Could not connect to server

    Do you have any limits for connections from other countries?

    Regards

    Avatar: 0rca
    0rca
    Participant
    August 1, 2019 at 17:11

    Hi Olga,

    WP login should work now and FTP is FTPS or SFTP only. Please use port 24 for the latter.

    Rgds.

    Michael

    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    August 1, 2019 at 17:50

    Hello,

    FTP is not for that dev site. We can see only 3 themes in the list in Dashboard http://prntscr.com/on3055 and 4 in the FTP http://prntscr.com/on30iu And we don’t see any reaction to our changes in files on the frontend. So, something is wrong with FTP.

    Would you be so kind to repeat me request that you sent to our support first time? Because our support member checked the code but doesn’t remember what exactly tried to implement, we have a lot of clients, sorry.

    Regards

    Avatar: 0rca
    0rca
    Participant
    August 1, 2019 at 20:14

    FTP is fixed, orginal request below

    Please contact administrator
    for this information.
    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    August 2, 2019 at 10:41

    Hello,

    1) Fixed. Changes were made in functions.php of child theme.
    2) We found incorrect quotes https://prnt.sc/ondhe0 Also you can disable unnecessary formats by changing width/height to 0 http://prntscr.com/ondqmk
    3) Because WooCommerce removed option to adjust gallery image size and left only single product and thumbnail size http://prntscr.com/ondrka
    By default gallery image is 100×100 and cropped without the option to change the size, so we decided to use shop catalog size.
    You can use the following code to limit thumbnails height

    .thumbnails-list .attachment-shop_catalog {
        max-height: 120px;
        width: auto;
    }

    Regards

    Avatar: 0rca
    0rca
    Participant
    August 2, 2019 at 11:43

    Excellent, thank you very much!

    Avatar: Rose Tyler
    Rose Tyler
    Support staff
    August 2, 2019 at 12:03

    Hello,

    You’re welcome!

    Regards

  • Viewing 8 results - 1 through 8 (of 8 total)

You must be logged in to reply to this topic.Log in/Sign up

We're using our own and third-party cookies to improve your experience and our website. Keep on browsing to accept our cookie policy.