XStore – getting conflict with etcore and third party plugin same issue

This topic has 20 replies, 4 voices, and was last updated 2 years, 3 months ago ago by Olga Barlow

  • Avatar: themadguru
    Robert
    Participant
    August 20, 2021 at 17:37

    Hello

    I originally posted about a conflict between XStore’s et-core-plugin and a popular news plugin called Epic News Elements. Both plugins were using the same name for a variable.

    Link to original problem here (opens in new tab)

    Screenshot of console with original error the last time I had an issue (link above):

    https://prnt.sc/r5zt4e

    Now I am getting the same problem, the WordPress customiser screen hangs when loading with a white screen. I checked the console and this time getting a similar error to previously getting:

    https://prnt.sc/1qd92qx

    In the original problem both etcore plugin and Epic News Elements plugin both used the same variable in their code called “repeater”, which caused the customizer to freeze when loading. Both XStore and Epic News Elements technical teams changed that variable so they no longer matched. Xstore changed it to jeg-repeater.

    Since the last update to XStore v8, there is now a new conflicting parameter called “params“, which is causing the customizer to freeze again. When I disable either of the plugins, it loads again. Same issue as before. Since it was SXtore that just changed the variable to “params“, please can your technical team look at this again and solve it? Is there a way that you can employ a naming convention for your variables that will not in future bring about this kind of conflict with third-party plugins using the exact same type of nomenclature? I’ve spent quite a while in the server security logs with no luck, and now Google console has provided me with the error.

    It must be common that multiple plugins use the customiser to allow end-users to change settings. However, no plugin should have a duplicate variable name with another plugin that causes the customiser to fail in this way. There must be a solution going forward. Just type “etcore-” in front of every customiser variable, or something shorter, just as a suggestion?

    Regards
    Robert

    19 Answers
    Avatar: Rose Tyler
    Rose Tyler
    Support staff
    August 21, 2021 at 08:36

    Hello,

    Please provide URL, temporary wp-admin, and FTP access. I will pass this topic to one of our developers.

    Regards

    Avatar: themadguru
    Robert
    Participant
    August 24, 2021 at 11:59

    Hi Rose

    Please see private content area for login credentials.

    Robert

    Please contact administrator
    for this information.
    Avatar: Rose Tyler
    Rose Tyler
    Support staff
    August 24, 2021 at 12:40

    Hello,

    Thanks for the reply. Your request was added to our task list, I will let you know once one of our developers check and solve it.
    We have a lot of requests, so take my apologies for the possible delay and be patient.

    Regards

    Avatar: themadguru
    Robert
    Participant
    August 24, 2021 at 12:56

    Hello Rose

    Thank you. It is not urgent, since that site is not an important one at this time.

    I have just sent a message to the Epic News Elements authors, as well, asking them to also alter their variable naming convention to avoid conflicts in future.

    It is worth noting for your developers, that WordPress provides best practices in order to avoid “Naming Collisions”:-

    https://developer.wordpress.org/plugins/plugin-basics/best-practices/

    Robert

    Avatar: Rose Tyler
    Rose Tyler
    Support staff
    August 25, 2021 at 09:00

    Hello,

    Thanks for the reply and understanding.

    Regards

    Avatar: Robert Hall
    Robert Hall
    Support staff
    September 1, 2021 at 00:28

    Hi Robert,

    Could you please send me zip file of Epic News Elements?

    Regards,

    Avatar: themadguru
    Robert
    Participant
    September 1, 2021 at 00:59

    Hello Robert Hall

    Please see the link in private area. The link expires in 3 days. Please let me know if there is anything else you need?

    Robert

    Please contact administrator
    for this information.
    Avatar: Robert Hall
    Robert Hall
    Support staff
    September 2, 2021 at 00:29

    Hello,

    Thank you for your report we will check and fix this issue in next tow updates.

    Regards,

    Avatar: themadguru
    Robert
    Participant
    September 19, 2021 at 04:09

    Hello Robert Hall

    I am just checking if there have been any developments yet? Also, what do you mean by tow updates? I do not know this term.

    Regards

    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    September 20, 2021 at 13:29

    Hello,

    Take our apologies. That was a misprint. Robert meant in one of the next two updates. We load customizer sections using ajax requests and lazy loading and looks that it causes the issue.
    Our developers working on updates of Royal, WooPress, Legenda themes and will be able to check these compatibility issues once finish these updates. Take our apologies for the delay.

    Regards

    Avatar: themadguru
    Robert
    Participant
    September 21, 2021 at 05:11

    Silly me. I should have realised that was “two” not two. I could kill my own phone for changing my spellings. LOL

    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    September 22, 2021 at 16:05

    Hello,

    It’s ok. That plugin also uses the Kirki framework and that’s the problem. Cause changing names is not really easy for Kirki, but developers looking for a workaround.

    Regards

    Avatar: themadguru
    Robert
    Participant
    December 16, 2021 at 15:59

    Hello Olga

    Is there any update from the developers? I have not heard back about this since September.

    Robert

    Avatar: themadguru
    Robert
    Participant
    December 22, 2021 at 19:18

    Hello

    Can someone take a look at this query again? it is not being looked at.

    Robert

    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    December 22, 2021 at 20:24

    Hello,

    Take my apologies for the delay in answering.
    Our developers tried to find the solution but with no luck at this moment. But we keep trying.

    Regards

    Avatar: themadguru
    Robert
    Participant
    December 22, 2021 at 22:19

    I don’t understand. It is exactly the same error message as a previously fixed problem, in which XStore used the same variable name as another plugin. At the start of this ticket, I posted the link to the problem that was fixed. Why not apply the same fix by changing the variable name. Since it wads XStore that named this variable on a recent update, conflicting with my Epic News plugin, then surely just why not change the variable name? WordPress has instructions on good practice for variable names so there are no conflicts with other plugins.

    Can you tell me why there is a delay, specifically, when a solution was previously found for the same error regarding another variable?

    Regards
    Robert

    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    December 23, 2021 at 16:38

    Hello,

    Tried to replace params but it does not help and causes even more problems. Looking for a way to disable Ajax loading of our options. Seems that conflicts with the mentioned plugin.

    Did you get any reply from plugin author? Do they have any idea about the mentioned issue?

    Regards

    Avatar: themadguru
    Robert
    Participant
    December 27, 2021 at 17:43

    Hello Olga

    I got an email yesterday from the Epic News Plugin author informing me he had found a fix on their end. I have tested the Epic News fix with XStore v8.0.11 and it now allows me to edit the theme options without it hanging. The fix appears to be working OK.

    If your developers want to liaise directly with the plugin author for more information about the fix, then I will put his email in the private content area. It’s up to you if you need to discuss anything with them to avoid future conflicts or understand better how the fix was applied.

    Thanks for your patience
    Robert

    Please contact administrator
    for this information.
    Avatar: Olga Barlow
    Olga Barlow
    Support staff
    December 28, 2021 at 14:35

    Hello,

    Glad to hear that. Thank you for the email. We’ll contact them.

    Regards

  • Viewing 20 results - 1 through 20 (of 20 total)

The issue related to '‘XStore – getting conflict with etcore and third party plugin same issue’' has been successfully resolved, and the topic is now closed for further responses

We're using our own and third-party cookies to improve your experience and our website. Keep on browsing to accept our cookie policy.