Return to previous page

Smart fixed menu, javascript scroll offset (bug), scroll to review section, ajax

This topic has 7 replies, 2 voices, and was last updated 8 years, 2 months ago ago by Olga Barlow

kumapanda

Participant

October 13, 2017 at 10:07

Hi there!
I found 3 bugs^^.

1. I like the new smart fixed menu. but there is a problem with page scroll animations. You put a “var top_offset” in javascript files… But when I choose the smart menu there is no need for a offset value. The value must be “0”.

Could you please fix that in the next release :)? I put an example in hidden content but I think you used the scroll offset severyl times in your javascript code…

2. Small issue is, that when I want to link to the review section I can not link to it… Please see the link in hidden content. “http://…../#reviews

Thank you very much!

Best,
Tobi

Please, contact administrator
for this information.

#175042 Copied Theme version: latest WooCommerce version: latest

6 Answers

kumapanda

Participant

October 13, 2017 at 13:40

Hello Olga,

I only see your answer as email…

That is correct:
2) Because that tab has different id http://……/#tab_reviews

But it doesnt work. You can try. The tab wont open…

Thank you!

#175073 Copied

Olga Barlow

Participant

October 13, 2017 at 16:09

Hello,

1) Developers ask if you are talking about startOffset maybe? Because there is no top_offset in js.
2) We have fixed the #reviews link. Try now.

Regards

#175100 Copied

kumapanda

Participant

October 15, 2017 at 19:50

Hello Olga,

#reviews link is working now. Please adapt it with the next update for other users ;)…

I tested the smart fixed menu and I think it is not so nice for the shopping experience because when you add a product to the cart you won’t see the “mini cart product add animation”. You see the “8” symbol while adding products to the cart, then it disappears and nothing :). So I think I will stick to the normal fixed menu. I modified the height of the fixed menu by myself so it wont hide so much of the content on smartphones :)…

The issue with the scroll fucntion is, that it is not scrolling far enough – especially on smartphones. My maximum top_offset should be 85px because that’s the maximum height of my fixed menu. Could you change this for all please? Please watch the video in hidden content.

THANKS!

Please, contact administrator
for this information.

#175196 Copied Theme version: latest WooCommerce version: latest

Olga Barlow

Participant

October 16, 2017 at 13:11

Hello,

Yes, reviews fix will be included.

Ok, we’ll try to improve sticky header.

Regards

#175246 Copied

kumapanda

Participant

October 16, 2017 at 13:13

Hi Olga,

thank you. But what is with the space when scroll to review? Will you fix this in next update :)?

#175247 Copied

Olga Barlow

Participant

October 17, 2017 at 09:55

Hello,

Yes, we’ll fix.

Regards

#175329 Copied
Viewing 7 results - 1 through 7 (of 7 total)