Return to previous page

One Page Menu and Anchor Text why the change to Id?

This topic has 4 replies, 3 voices, and was last updated 10 years, 1 months ago ago by Eva Kemp

ckitso

Participant

October 24, 2015 at 09:53

Hi after your recent update I noticed that your code has changed regarding using row Id’s instead of row anchors for your one page navigation.

As such your etheme.js has changed as has your vc.php and you have removed vc_rows.php

Unfortunately these changes have caused my mobile menu’s to not function correctly.

Can I ask why this method was employed and why you removed the anchor option from vc.php.

I have had to modify the code to re-add the anchor option and use this instead of row id’s and now the menu’s work flawlessly. But obviously moving forward with updates Id like to know the logic behind the move so that I can maintain my own code in line with what you have planned.

Kind Regards

#95871 Copied

3 Answers

Stan Russell

Participant

October 24, 2015 at 11:32

Hello ckitso,

those changes were made because we have added new feature “full page sections”: https://www.8theme.com/demo/royal/demo61/
Visual Composer Row ID is used now for one page navigation: https://www.8theme.com/demo/docs/royal/#!/3_one_page
Please edit your page according to these new rules and accept our apologies for this little inconvenience.
In case you will find any bug in our theme caused by these changes – please let us know.

Regards,
Stan Russell.

#95874 Copied

ckitso

Participant

October 30, 2015 at 12:12

Hi thank you for the response.
There is a definite bug while using Id’s. The menu in mobile fails to shift back after selecting a menu. But as this is a live site ill keep the anchor variables for now. And readdress the issue when I update at a later stage.

I have also noticed that the theme has a major css flaw when it comes to full stretched rows. Particularly on mobile when using the menu. It crops off half of the full width background image or colour. And one needs to refresh the page in order for the rows background to resize correctly. This is evident when one rotates a mobile as well. You can see it clearly on the demo link you provided above.

From what I can see the problem lies with the way you do full width content. From what I can see is that you dynamically add the style to the div on execution so it scales to fit the chrome window, in order to overcome the themes container div width restraints. However on rotation or using the menu there is no refresh so the dynamic style doesn’t adjust to the new scree size and is thus cropped off.

The only solution to this that I can see is a redesign of the sites core layout with each section using its own container width instead of being wrapped in a site wide container to avoid the screen rotation problem. And possibly using a normal drop down menu in mobile as opposed to an off site slider as you currently have.

Are you aware of this bug?

#96980 Copied

Eva Kemp

Participant

November 2, 2015 at 11:49

Hello,

Thank you for your notice.
We’ll try to improve the functionality in the theme update.

Please take our apologies for inconveniences.

Regards,
Eva Kemp.

#97261 Copied
Viewing 4 results - 1 through 4 (of 4 total)