Return to previous page

Fix 2 optimizing-issues with the next update please…

This topic has 15 replies, 2 voices, and was last updated 6 years, 4 months ago ago by Olga Barlow

kumapanda

Participant

November 15, 2017 at 17:04

Hello,

Can you please fix that in the next theme update:
1.)
Resources with a “?” in the URL are not cached by some proxy caching servers. Remove the query string and encode the parameters into the URL for the following resources:
/wp-content/themes/xstore/fonts/fontawesome-webfont.woff2?v=4.7.0
/wp-content/themes/xstore/fonts/xstore-icons.ttf?zdg2u0
2.)
The following cacheable resources have a short freshness lifetime. Specify an expiration at least one week in the future for the following resources:
https://fonts.googleapis.com/css?family=Raleway%3A700%7COpen+Sans%3A400%7CRaleway%3A500

Then I will get a 100 rating at pingdom with your theme ;)…

THANK YOU!

#177703 Copied

14 Answers

kumapanda

Participant

November 16, 2017 at 01:05

Can you give me an advice how to I need to set up my images that the resizing issue of my images in google is solved? And the images are still sharp? Please visit the page speed link in hidden content…

Please, contact administrator
for this information.

#177734 Copied

Olga Barlow

Support staff

November 16, 2017 at 14:52

Hello,

1) Please check this article or plugin:
http://diywpblog.com/wordpress-optimization-remove-query-strings-from-static-resources/
http://wordpress.org/plugins/remove-query-strings-from-static-resources/
2) Please check this article https://makeaweblog.com/how-to-leverage-browser-caching-in-wordpress/
3) You can optimize images using special services
– tinypng.com
– Compressor.io
– Kraken.io
– Ewww Image Optimizer
– Smush Image Compression and Optimization plugin

Regards

#177811 Copied

kumapanda

Participant

November 16, 2017 at 15:12

Hello Olga,

1. that issues are on your end. The two files are from xstore and wprocket do not strip the query strings. Can you please fix that? Only that 2 files.

2. Can you load the font awesome maybe in another way? WP Rocket don’t optimize the font the way you added it.

3. I optimized my images with such a program. That’s not the point. The point is the resizing issue…

Looking forward to hearing from you!

#177818 Copied

Olga Barlow

Support staff

November 20, 2017 at 14:52

Hello,

1) We’ll change it in next theme update.
2) You have asked about https://fonts.googleapis.com/css?family=Raleway%3A700%7COpen+Sans%3A400%7CRaleway%3A500 don’t understand your answer about fontawesome.
3) Unfortunately, WC has only 3 variants of the images – catalog, single product, thumbnails. And we use them for appropriate images in our theme. So, you may go to WooCommerce > Settings > Products > Display > change catalog images to 300×300 and regenerate thumbnails. Check if it helps.

Regards

#178073 Copied

kumapanda

Participant

November 20, 2017 at 17:56

1) Perfect!

2) Normally WP Rocket optimize the integration of google fonts but with XStore theme it isn’t working… and Google Page Speed dropfs that error…. Can you integrate Google Fonts in a corect way please :)?

3) Ok I will try but I think the images won’t be sharp anymore, exspecially on iPad, because the columns are much bigger in vertical view.

4) I saw you added styling options for buttons. But this will not style the cart or chackout buttons or other woocommerce buttons… (at the moment Im using custom css)

5) The styling options for the navigation doesn’t apply for the fixed header menu! Second is, it is not possible to change the color of the expanding border while hover the primary items. (at the moment Im using custom css)

Best regards,

Tobias

#178117 Copied

Olga Barlow

Support staff

November 21, 2017 at 16:12

Hello,

2) Google fonts are integrated in right way. Provide me temporary admin panel and FTP access to check the settings.
4) It styles. We have 3 types of buttons on our site – light (for example http://prntscr.com/hdcwhy), dark (for example http://prntscr.com/hdcwxi), active (for example http://prntscr.com/hdcx3r) and you can style them all via theme options http://prntscr.com/hdcxly
5) We’ll add options for the fixed header and border in next theme update.

Regards

#178221 Copied

kumapanda

Participant

November 21, 2017 at 16:21

Thank you Olga for your qualitative answers :). Ok. Now I get it with the styling, big thanks for clarification!!!

Regarding the Google Font issue. I will make a staging Site, so that you can have a look inside it :).

#178224 Copied

Olga Barlow

Support staff

November 21, 2017 at 16:56

You are welcome. Reply back once staging site will be ready.

Regards

#178235 Copied

kumapanda

Participant

November 22, 2017 at 10:54

Hi Olga,

I sorted it out! The only thing is the 2 query strings, which will you remove with the next updates :).

Regarding the custom css loading in xstore. I think all styles, which the user sets in backend theme options, are loading in the header as inline script. I have two concerns with this:

1. It would be better to not load those styles inline.
2. Perfect would be:
a) that a css file is generated when theme options are saved every time.
b) Instead of overriding default styles it should be replace the default styles, that’s why to generate a “custom css” file every time.

I did a bit investigation and found that article about redux:
https://docs.reduxframework.com/core/advanced/updating-a-css-file-dynamically/

To prevent duplicate styles loaded from normal Xstore styles.css and newly generated custom.css, easely remove those styles which can be set in theme options in styles.css…

That’s what we need :)!

What do you think? In my opionion it will give xstore theme a nice boost because it’s not necessary to load duplicate styles anymore!

Best regards,

Tobias

#178293 Copied

Olga Barlow

Support staff

November 22, 2017 at 14:32

Hello,

It’s the interesting idea to use the autogenerated file. I think we’ll implement this.
But we won’t delete default styles because if the user did not set header background color, for example, theme should display default color.

Regards

#178341 Copied

kumapanda

Participant

November 22, 2017 at 15:47

Hi Olga! Great news :))).

Do you not think it’s possible to store either default or custom values in the newly generated css? Would be awesome… Or it would be no problem to remove it, when there are default values from the start in the options? So there would be no need for duplicate styles…

#178360 Copied

Olga Barlow

Support staff

November 23, 2017 at 11:10

Hello,

I can’t answer these questions till we try to implement this.

Regards

#178437 Copied

kumapanda

Participant

December 7, 2017 at 11:35

Do you have an update for me? Then I can make the css changes in the theme options^^…

#179572 Copied

Olga Barlow

Support staff

December 7, 2017 at 17:16

Hello,

I don’t have the positive answer at this moment. Our developers are working on other complicated option and once they finish it they will be able to start with this improvement.

Regards

#179620 Copied
Viewing 15 results - 1 through 15 (of 15 total)