Return to previous page

Child Theme – Sorry, More Issues - by khoavo

This topic has 13 replies, 3 voices, and was last updated 10 years, 8 months ago ago by Eva Kemp

khoavo

Participant

April 8, 2015 at 20:13

Hey, sorry, I closed out this Topic too soon.

Just did a test and the Child Theme’s shortcodes.php is not working yet.

I edited the [shared] shortcode in shortcodes.php. I uploaded my edited php version to the royal-child/framework folder and uploaded the un-edited shortcodes.php into the royal/framework folder. And I’m supposed see the changes from my edited version, but the site is showing the original, non-changed icons. Thanks.

#55773 Copied

12 Answers

Brian Johnson

Member

April 9, 2015 at 09:14

Please provide us with ftp credentials to your site.

With best regards
Brian Johnson

#55872 Copied

khoavo

Participant

April 9, 2015 at 20:58

Hey there, are you guys doing something to my Site right now? I just logged on to view and the page header looks different. I had provided you my FTP info so you can fix the shortcodes.php issue. If you’re doing testing on it, let me know and I’ll wait until you’re done.

Thanks again.

#56091 Copied

khoavo

Participant

April 10, 2015 at 02:35

I just logged in again, 8 hours later, now my Client’s logo is not appearing on the site. I’m seeing the ROYAL Theme logo. The deader padding for my custom logo was changed as well as the link colors for the link items i the header.

PLEASE LET ME KNOW IF YOUR TEAM DID SOME TESTING OR ADJUSTMENTS AFTER I HAD PROVIDED YOU WITH ME FTP CREDENTIALS? The problem was to fix the Child Theme (shortcodes.php and the share shortcode). MY CLIENT IS ASKING ME HOW COME THE LOGO IS GONE AND OTHER THINGS.

LET ME KNOW SOON PLEASE. THANK YOU.

Please, contact administrator
for this information.

#56106 Copied

Eva Kemp

Participant

April 10, 2015 at 09:35

Hello,

The problem was caused by the plugin Instagram Feed. I’ve disabled it.
Please check the site now and clear browser cache before.

Thank you.
Regards,
Eva Kemp.

#56150 Copied

khoavo

Participant

April 10, 2015 at 09:51

Oh goodness! Maybe the conflict occurred after I did an update for the Instagram Plugin. Can I try another Instagram Feed? or does your theme not compatible with Instagram at all?

But the original issue regarding my shortcodes.php has not be fixed. I have my edited version of shortcodes.php in my royal-child/framework folder. It’s supposed to overwrite what’s included in the royal/framework folder, but that’s not the case. I’ve activated the Child Theme to avoid my changes being erased during a Theme Update.

Also, I was asking if you could provide me with the line of codes to include for INSTAGRAM Sharing as part of the [share] shortcode. Thanks.

#56156 Copied

Brian Johnson

Member

April 10, 2015 at 10:42

Hello

Sorry for the long delay with answer.
We changed child-theme structure for a while. We have added default 2 files from main theme and now they are removed. Please check your site now. No customization in settings or css modifications was made. Currently we are working for the solution for your issue and will reply as soon as possible.
Thank you for understanding.

With best regards
Brian Johnson

#56167 Copied

khoavo

Participant

April 10, 2015 at 10:57

Okay, so right now, my custom.css is located in the royal folder, not royal-child. Is that okay to leave as is and the future Theme Update will not effect it?

As for my edited version of the shortcodes.php file, located in royal-child/framework, that contains the edited codes of how I want the share icons to be display on my main menu bar, which is: Twitter, FB, Pinterest G+ AND I like to add the INSTAGRAM Share Icon as well, so hopefully you’re able to provide me that added line of codes.

I’m hoping you’re able to resolve the child-theme issue. If needed, I can temporarily upload my edited version shortcodes.php into the royal/framework. But I’m sure you’ll be able to help me solve it soon. Thanks again.

#56173 Copied
Brian Johnson

Member

April 11, 2015 at 12:28
Hello

The issue has been fixed. Please check your site now. Regarding the shortcode function it can not be overwritten using just simple file replacement. In case you want to change some functions from theme files please add your modifications to the functions.php of your child theme and if they are not wrapped in if (function_exists('functon')) you should remove them on load and add your child customization.
I have added following lines of code to the fuctions.php:

function remove_parent_functions() { remove_shortcode('share', 'etheme_share_shortcode'); add_shortcode('share', 'etheme_share_shortcode_child'); } add_action('init','remove_parent_functions'); function etheme_share_shortcode_child($atts, $content = null) {

….your custom function.

With best reagrds
Brian Johnson
#56350 Copied
khoavo

Participant

April 11, 2015 at 18:02

Thanks for this. Could you please let me know how to add INSTRAGRAM to the share group as well? Place it right after the Pinterest share.

And I don’t know what you mean by “if they are not wrapped in if (function_exists(‘functon’)) you should remove them on load…

#56368 Copied
Eva Kemp

Participant

April 12, 2015 at 09:49
Hello,

I’ve added this code in functions.php to add Instagram icon:

<li> <a href="http://instagram.com/?url='.$permalink.'&media='.$image.'&description='.$post_title.'" title="'.__('Share On Instagram', ETHEME_DOMAIN).'" target="_blank"> <i class="ico-instagram"></i> <svg width="38" height="38" xmlns="http://www.w3.org/2000/svg" class="circle"> <circle cx="19" cy="19" r="18" fill="rgba(255,255,255,0)" stroke="#cda85c"></circle></svg> </a> </li>

Please check now.

Regards,
Eva Kemp.
#56404 Copied
khoavo

Participant

April 12, 2015 at 10:19

Beautiful! It’s looks nicer now. Excellent customer support from your group! Thank you.

Please close out this ticket as well.

#56408 Copied

Eva Kemp

Participant

April 12, 2015 at 10:24

Hello,

You’re always welcome.

Regards,
Eva Kemp.

#56413 Copied
Viewing 13 results - 1 through 13 (of 13 total)