Reply 178293 to: Fix 2 optimizing-issues with the next update please…

Avatar: kumapanda
kumapanda
Participant
November 22, 2017 at 10:54

Hi Olga,

I sorted it out! The only thing is the 2 query strings, which will you remove with the next updates :).

Regarding the custom css loading in xstore. I think all styles, which the user sets in backend theme options, are loading in the header as inline script. I have two concerns with this:

1. It would be better to not load those styles inline.
2. Perfect would be:
a) that a css file is generated when theme options are saved every time.
b) Instead of overriding default styles it should be replace the default styles, that’s why to generate a “custom css” file every time.

I did a bit investigation and found that article about redux:
https://docs.reduxframework.com/core/advanced/updating-a-css-file-dynamically/

To prevent duplicate styles loaded from normal Xstore styles.css and newly generated custom.css, easely remove those styles which can be set in theme options in styles.css…

That’s what we need :)!

What do you think? In my opionion it will give xstore theme a nice boost because it’s not necessary to load duplicate styles anymore!

Best regards,

Tobias

Go To The Whole Conversation In Topic
We're using our own and third-party cookies to improve your experience and our website. Keep on browsing to accept our cookie policy.